Never use android.R.strings; remove unused add string#7024
Merged
Stypox merged 3 commits intoTeamNewPipe:devfrom Aug 31, 2021
Merged
Never use android.R.strings; remove unused add string#7024Stypox merged 3 commits intoTeamNewPipe:devfrom
android.R.strings; remove unused add string#7024Stypox merged 3 commits intoTeamNewPipe:devfrom
Conversation
triallax
added
the
localisation / translation
TobiGr
approved these changes
Aug 30, 2021
Contributor
|
@Stypox thank you for doing this |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
finish, whose content was "OK", tookandroid.R.string.yesandandroid.R.string.okwithR.string.okandroid.R.string.noandandroid.R.string.cancelwithR.string.canceladd(legacy left behind from the downloader)FeedGroupDialog, solving Android Studio warningsFixes the following issue(s)
Fixes #6848 (comment)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
@nadiration could you check if this works well?
Due diligence